Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed errors #582

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Removed errors #582

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/ember-w-pack/addon/components/w-async.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ export default class WAsyncComponent extends Component {
layout = layout

didReceiveAttrs() {
this._super(...arguments);
super.init(...arguments);
if (this.autoFire) this.task.perform();
}

Expand Down
2 changes: 1 addition & 1 deletion lib/ember-w-pack/addon/components/w-pagination.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ export default class WPaginationComponent extends Component {


didReceiveAttrs() {
this._super(...arguments);
super.init(...arguments);
const length = this.pages;
this.set(
"pagesArray",
Expand Down
8 changes: 4 additions & 4 deletions lib/ember-w-pack/addon/templates/components/w-async.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
{{#if showLoader}}
{{#if loaderComponent}}
{{loaderComponent}}
{{#if @showLoader}}
{{#if @loaderComponent}}
<loaderComponent></loaderComponent>
{{else}}
Loading...
{{/if}}
{{else}}
{{yield task.last.value}}
{{yield @task.last.value}}
{{/if}}
6 changes: 3 additions & 3 deletions lib/ember-w-pack/addon/templates/components/w-pagination.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
{{#if showComponent}}
{{#if @showComponent}}
<div class="t-align-c mt-3 bold">
<button disabled="{{if disabledPrevious 'disabled'}}" {{action 'previousPage'}}>
<button type="button" disabled="{{if @disabledPrevious 'disabled'}}" {{on 'previousPage'}}>
&lt; Prev
</button>
<span class="dark-grey mx-4">
{{this.start}}-{{this.end}} of {{this.numberOfTotalResults}}
</span>

<button disabled="{{if disabledNext 'disabled'}}" {{action 'nextPage'}}>
<button type="button" disabled="{{if @disabledNext 'disabled'}}" {{on 'nextPage'}}>
Next &gt;
</button>

Expand Down
7 changes: 4 additions & 3 deletions lib/ember-w-pack/addon/templates/components/w-tab-nav.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
<div class="tab-nav-underline w-100 justify-content-start t-align-c {{tabClass}}">
{{#each @tabs as |tab index|}}
<div class="tab px-0 mr-md-5 mr-sm-4 mr-3 font-sm bold {{if (eq tab activeTab) 'active' inactiveClass}}" {{on "click" (action @onTabChange tab)}}>{{tab.name}}</div>
<div class="tab-nav-underline w-100 justify-content-start t-align-c {{@tabClass}}">
{{#each @tabs as |tab|}}
<div class="tab px-0 mr-md-5 mr-sm-4 mr-3 font-sm bold {{if (eq tab @activeTab) 'active' @inactiveClass}}"
{{on "click" (on @onTabChange tab)}} role="button">{{tab.name}}</div>
{{/each}}
</div>
<div>
Expand Down