Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed view preview button with its associated code #1031

Merged
merged 4 commits into from
Sep 24, 2024

Conversation

Prakhar29Sharma
Copy link
Contributor

✨ Codu Pull Request 💻

Fixes #1022

Pull Request details

  • Removed button element from app>(app)>alpha>new
  • Removed state variable (viewPreview, setViewPreview) that was being changed when button was clicked using onClick()
  • Removed code that was being rendered when viewPreview was set to true

Any Breaking changes

  • I removed viewPreview and setViewPreview from hooks/useCreatePage.ts, I'm not sure if it'll cause any issue
  • I was not able to test the changes properly as I was having issues with setting up codu in my local dev environment

Associated Screenshots

  • 'None'

@Prakhar29Sharma Prakhar29Sharma requested a review from a team as a code owner September 24, 2024 08:59
Copy link

vercel bot commented Sep 24, 2024

@Prakhar29Sharma is attempting to deploy a commit to the Codú Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Contributor

coderabbitai bot commented Sep 24, 2024

Walkthrough

The changes involve the removal of the viewPreview state and its associated functionality from the Create component and the useCreatePage hook. This streamlining eliminates the preview button and related code, simplifying the structure of the editor in the alpha section of the application.

Changes

Files Change Summary
app/(app)/alpha/new/[[...postIdArr]]/_client.tsx, hooks/useCreatePage.ts Removed viewPreview state and setViewPreview function, along with the preview button and related logic.

Assessment against linked issues

Objective Addressed Explanation
Remove the preview button to make editor WYSIWYG (#1024)
Switch to a simpler interface for the editor (#1022) The overall interface simplification is not yet complete.

Poem

🐰 In the code where rabbits play,
The preview's gone, hip-hip-hooray!
A simpler path, we leap and bound,
In the WYSIWYG, joy is found!
With every change, our dreams take flight,
Hopping towards a future bright! 🌟


Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between c035050 and 10c05fc.

Files selected for processing (1)
  • app/(app)/alpha/new/[[...postIdArr]]/_client.tsx (1 hunks)
Files skipped from review as they are similar to previous changes (1)
  • app/(app)/alpha/new/[[...postIdArr]]/_client.tsx

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    -- I pushed a fix in commit <commit_id>, please review it.
    -- Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    -- @coderabbitai generate unit testing code for this file.
    -- @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    -- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    -- @coderabbitai read src/utils.ts and generate unit testing code.
    -- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    -- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

Hello @Prakhar29Sharma, thanks for opening your first Pull Request. The maintainers will review this Pull Request and provide feedback as soon as possible. Keep up the great work!

@John-Paul-Larkin
Copy link
Member

The PR looks good.
However I got a linting error. Simple fix. Just run the following script.
Thanks

npm run prettier:fix

@Prakhar29Sharma
Copy link
Contributor Author

Hey @John-Paul-Larkin
Thanks for the feedback, I've fixed the linting error by running the given script. If there's anything else let me know.

Copy link

vercel bot commented Sep 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
codu ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 24, 2024 2:48pm

@John-Paul-Larkin John-Paul-Larkin merged commit 8433835 into codu-code:develop Sep 24, 2024
3 checks passed
@NiallJoeMaher
Copy link
Contributor

Nice one @Prakhar29Sharma! Thanks

@John-Paul-Larkin
Copy link
Member

Hey @John-Paul-Larkin Thanks for the feedback, I've fixed the linting error by running the given script. If there's anything else let me know.

Great work Prakhar29Sharma.
Congratulations on your first contribution to open source. 🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Meta issue : Editor
3 participants