Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix footer not sticky on the bottom #1173

Closed
wants to merge 5 commits into from
Closed

Fix footer not sticky on the bottom #1173

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
be58ca5
fix: footer
lindotex Oct 24, 2024
ce501d5
fix: Footer didn't stick to the bottom.
lindotex Oct 24, 2024
6feef43
fix: Footer sticking at the bottom of the page
lindotex Oct 25, 2024
4fd6b4f
Merge branch 'develop' into fix-footer-not-sticky-on-the-bottom
lindotex Oct 26, 2024
b9ce635
Merge branch 'develop' into fix-footer-not-sticky-on-the-bottom
NiallJoeMaher Oct 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 9 additions & 7 deletions app/(app)/layout.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,13 +79,15 @@ export default async function RootLayout({

return (
<>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No longer need the fragments. Let me know if you have time to update this.

<Nav
session={session}
algoliaSearchConfig={algoliaSearchConfig}
username={userData?.username || null}
/>
{children}
<Footer />
<div className="grid min-h-screen grid-rows-[auto_1fr_auto]">
<Nav
session={session}
algoliaSearchConfig={algoliaSearchConfig}
username={userData?.username || null}
/>
{children}
<Footer />
</div>
</>
);
}
2 changes: 1 addition & 1 deletion app/(app)/my-posts/_client.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ const MyPosts = () => {
cancelText="Cancel"
/>
)}
<div className="relative mx-4 max-w-2xl bg-neutral-100 dark:bg-black sm:mx-auto">
<div className="w-auto sm:w-full relative mx-4 max-w-2xl bg-neutral-100 dark:bg-black sm:mx-auto">
<div className="mb-4 mt-8">
<Tabs tabs={tabs} />
</div>
Expand Down
Loading