-
-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create GitHub action to check pull requests #654
Conversation
This reverts commit 132b9ea.
@thanhsonng is attempting to deploy a commit to the Codú Team on Vercel. A member of the Team first needs to authorize it. |
Pending itemsSome pending items need further discussion and should be handled after this PR: Lint warningsCurrently there are a lot of ESLint warnings. Some easy ones that can be quickly fixed are TypeScript checksSimilarly, there are lots of TS errors, and they make the check fail (that's why I don't include a TS check in this PR). Type fixes can be complex and therefore should have its own PR and discussion. Playwright testsHonestly I don't know enough about Playwright and Prisma to include it in this GH Action at the moment. |
@thanhsonng this is amazing! I have a PR open with Playwright so between us this should catch most things. |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🌮 Fantastic addition!
@NiallJoeMaher Thanks for merging, it's a pleasure to contribute as always 🚀 |
✨ Codu Pull Request 💻
Pull Request details:
npm run lint
npm run prettier
(this command is a breaking change, see below)npm run test:jest
Any Breaking changes:
npm run prettier
will also fix the styling errors detected by Prettier. This command now only checks for errors. To fix them automatically as before, usenpm run prettier:fix
.Associated Screenshots:
Each Pull request will have an action like this moving forward.
Click on Details to see how each step runs.