Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(eslint): add lint check to precommit #671

Merged
merged 1 commit into from
Dec 13, 2023

Conversation

xiaoniuniu89
Copy link
Contributor

โœจ Codu Pull Request ๐Ÿ’ป

Codu Logo

๐Ÿ‘‰ Please remove the below and replace with your own values, leaving the headers where they are. ๐Ÿ‘ˆ

Pull Request details:

add lint precommit check. This will save time debugging broken builds in vercel that are from unlinted files

Any Breaking changes:

commit will fail if eslint error in js(x)/ts(x) files

Associated Screenshots:

( Welcome file extensions include gifs/png screenshots of your feature in action )

  • IF YOU HAVE ANY SCREENSHOTS, INCLUDE THEM HERE.
  • IF YOU HAVE NO SCREENSHOTS, ENTER 'None'

Copy link

vercel bot commented Dec 12, 2023

@xiaoniuniu89 is attempting to deploy a commit to the Codรบ Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Contributor

@NiallJoeMaher NiallJoeMaher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks! ๐ŸŒฎ

Copy link

vercel bot commented Dec 12, 2023

The latest updates on your projects. Learn more about Vercel for Git โ†—๏ธŽ

Name Status Preview Comments Updated (UTC)
codu โœ… Ready (Inspect) Visit Preview ๐Ÿ’ฌ Add feedback Dec 12, 2023 9:43pm

@NiallJoeMaher NiallJoeMaher merged commit 22210df into codu-code:develop Dec 13, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants