refactor: use native css for globals #20
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomrav
previously approved these changes
May 7, 2023
idoros
dismissed
tomrav’s stale review
it seems codux doesnt support stylable importing native css
|
In order to merge this change, Codux need to implement native CSS loaded from stylable files, which seems to be missing atm. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stylable can now import native CSS and use it's global definitions.
This PR Refactor the
globals.st.cssinto a native.cssthat doesn't need all the:global()wrappers, since native css is global by default, and can be imported by another stylable file.