Update URLs & readme #307
Merged
Update URLs & readme #307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to create a cursor, the journal must be at a valid entry. As
the docs say:
Note that sd_journal_get_cursor() will not work before
sd_journal_next(3) (or related call) has been called at least
once, in order to position the read pointer at a valid entry.
The existing tests do this, but at least on recent versions of
systemd (255), calling sd_journal_next after a seek to tail does not
meet this requirement. If the journal is at the tail, subsequent nexts
will always stay a the abstract 'tail' position (analogous to
EOF), not at a valid entry. This causes cursor creation to fail.
A similar issue exists in the 'match' test. It seeks to tail and then
attempts to 'next' in a loop, but this will always be 'tail', so it
never sees the matching entry. In both cases, the fix is to 'previous'
after the seek to tail.
…into url (#305) Adding this in so tests can pass.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.