Delete unused ExpressionFuzzer::generateXxxArgs methods (facebookincu…

…bator#9256) Summary: Pull Request resolved: facebookincubator#9256 Reviewed By: pedroerp Differential Revision: D55368519 fbshipit-source-id: 1d1759ae7dd6c20a6acc10e0d1104098dad39de1
codyschierbeck · Mar 26, 2024 · 2d832ee · 2d832ee
1 parent 0618c7f
commit 2d832ee
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 37 deletions.
diff --git a/velox/expression/tests/ExpressionFuzzer.cpp b/velox/expression/tests/ExpressionFuzzer.cpp
@@ -940,28 +940,6 @@ core::TypedExprPtr ExpressionFuzzer::generateArg(
   }
 }
 
-// Specialization for the "empty_approx_set" function: first optional
-// parameter needs to be constant.
-std::vector<core::TypedExprPtr> ExpressionFuzzer::generateEmptyApproxSetArgs(
-    const CallableSignature& input) {
-  if (input.args.empty()) {
-    return {};
-  }
-  return {generateArgConstant(input.args[0])};
-}
-
-// Specialization for the "regexp_replace" function: second and third
-// (optional) parameters always need to be constant.
-std::vector<core::TypedExprPtr> ExpressionFuzzer::generateRegexpReplaceArgs(
-    const CallableSignature& input) {
-  std::vector<core::TypedExprPtr> inputExpressions = {
-      generateArg(input.args[0]), generateArgConstant(input.args[1])};
-  if (input.args.size() == 3) {
-    inputExpressions.emplace_back(generateArgConstant(input.args[2]));
-  }
-  return inputExpressions;
-}
-
 std::vector<core::TypedExprPtr> ExpressionFuzzer::generateSwitchArgs(
     const CallableSignature& input) {
   VELOX_CHECK_EQ(

diff --git a/velox/expression/tests/ExpressionFuzzer.h b/velox/expression/tests/ExpressionFuzzer.h
@@ -239,21 +239,6 @@ class ExpressionFuzzer {
 
   core::TypedExprPtr generateArg(const TypePtr& arg, bool isConstant);
 
-  /// Specialization for the "like" function: second and third (optional)
-  /// parameters always need to be constant.
-  std::vector<core::TypedExprPtr> generateLikeArgs(
-      const CallableSignature& input);
-
-  /// Specialization for the "empty_approx_set" function: first optional
-  /// parameter needs to be constant.
-  std::vector<core::TypedExprPtr> generateEmptyApproxSetArgs(
-      const CallableSignature& input);
-
-  /// Specialization for the "regexp_replace" function: second and third
-  /// (optional) parameters always need to be constant.
-  std::vector<core::TypedExprPtr> generateRegexpReplaceArgs(
-      const CallableSignature& input);
-
   // Return a vector of expressions for each argument of callable in order.
   std::vector<core::TypedExprPtr> getArgsForCallable(
       const CallableSignature& callable);