Skip to content

Commit

Permalink
Fix flaky MultiFragmentTest.partitionedOutputWithLargeInput (facebook…
Browse files Browse the repository at this point in the history
…incubator#9147)

Summary:
Fix the flaky test by creating leaf task with more memory capacity. The flaky
test now passed 1000 iterations in Meta internal

Pull Request resolved: facebookincubator#9147

Reviewed By: Yuhta, mbasmanova

Differential Revision: D55055257

Pulled By: xiaoxmeng

fbshipit-source-id: 37c169fed5971bbde8f18c50792c7e6c4c1e8251
  • Loading branch information
xiaoxmeng authored and facebook-github-bot committed Mar 19, 2024
1 parent 3e13ff5 commit 813c4b4
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions velox/exec/tests/MultiFragmentTest.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -579,7 +579,6 @@ TEST_F(MultiFragmentTest, partitionedOutputWithLargeInput) {
// This test exercises splitting up the input both from the edges and the
// middle as it ends up splitting it into at least 3.
setupSources(1, 30'000);
const int64_t kRootMemoryLimit = 1 << 20; // 1MB
// Single Partition
{
auto leafTaskId = makeTaskId("leaf", 0);
Expand All @@ -588,8 +587,7 @@ TEST_F(MultiFragmentTest, partitionedOutputWithLargeInput) {
.values(vectors_)
.partitionedOutput({}, 1, {"c0", "c1", "c2", "c3", "c4"})
.planNode();
auto leafTask =
makeTask(leafTaskId, leafPlan, 0, nullptr, kRootMemoryLimit);
auto leafTask = makeTask(leafTaskId, leafPlan, 0, nullptr, 4 << 20);
leafTask->start(1);
auto op = PlanBuilder().exchange(leafPlan->outputType()).planNode();

Expand Down

0 comments on commit 813c4b4

Please sign in to comment.