Skip to content
This repository has been archived by the owner on Jun 23, 2023. It is now read-only.

Show a message when demo recording starts. #517

Merged

Conversation

JadingTsunami
Copy link
Collaborator

Address #515 by printing a message to the user's view when recording begins.

@fabiangreffrath
Copy link
Collaborator

As already stated earlier, I like the idea to provide confirmation to the player that a demo is recording. @rfomin What do you say for Woof?

@rfomin
Copy link
Contributor

rfomin commented Jul 12, 2022

As already stated earlier, I like the idea to provide confirmation to the player that a demo is recording. @rfomin What do you say for Woof?

But we have a PR for parameter validation in Woof.

@fabiangreffrath
Copy link
Collaborator

But we have a PR for parameter validation in Woof.

Just as an additional confirmation for the user that the current run is recorded. I see this independent from command line validation.

@rfomin
Copy link
Contributor

rfomin commented Jul 12, 2022

Just as an additional confirmation for the user that the current run is recorded. I see this independent from command line validation.

Okay, sure.

@fabiangreffrath
Copy link
Collaborator

@JadingTsunami Could you consider this solution?

fabiangreffrath/woof@bf27105

@JadingTsunami
Copy link
Collaborator Author

@JadingTsunami Could you consider this solution?

fabiangreffrath/woof@bf27105

Sure, I am fine with that as well. The downside of hard-coding the message is that it is not possible to localize it through a patch anymore. But I am not sure anyone would have a strong feeling about it; it may not matter in the end.

@JadingTsunami
Copy link
Collaborator Author

Some updates after adopting the proposed approach from @fabiangreffrath.

  • record will print the demo filename being recorded to.
  • -recordfromto now shows when recording continues (which is a welcome addition, I think).

@fabiangreffrath
Copy link
Collaborator

Very nice, thank you!

@fabiangreffrath fabiangreffrath merged commit 701f12f into coelckers:master Jul 14, 2022
@JadingTsunami JadingTsunami deleted the show_message_when_recording branch February 8, 2023 15:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants