Make Clusters a top-level entity in the data model #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Found a bug - custom Helm values overrides aren't persisted. |
This change modifies cofidectl to adapt to the changes in cofide/cofide-api-sdk#29 in which: - the Clusters field has been removed from the TrustZone message - a Clusters field has been added to the Config message - AddCluster, GetCluster and ListClusters RPCs have been added to the DataSourcePluginService Clusters are now a top-level entity in the data model, rather than embedded in trust zones. As such, Cluster objects are now retrieved via the DataSource interface. The limitation of one cluster per trust zone remains, and clusters are not exposed in the CLI. Fixes: #127
markgoddard
force-pushed
the
issues/127
branch
from
375a00c to
3d1cc3e
Compare
Fixed. |
kipz
reviewed
Feb 7, 2025
jsnctl
reviewed
Feb 10, 2025
nialdaly
reviewed
Feb 10, 2025
nialdaly
approved these changes
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change modifies cofidectl to adapt to the changes in
cofide/cofide-api-sdk#29 in which:
DataSourcePluginService
Clusters are now a top-level entity in the data model, rather than
embedded in trust zones. As such, Cluster objects are now retrieved via
the DataSource interface.
The limitation of one cluster per trust zone remains, and clusters are
not exposed in the CLI.
Fixes: #127