Skip to content

Commit

Permalink
Remove dependency var check when setting up certificate
Browse files Browse the repository at this point in the history
  • Loading branch information
bisera-cognite committed Aug 31, 2023
1 parent f876055 commit 2c023b4
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 7 deletions.
8 changes: 4 additions & 4 deletions .github/workflows/run-action.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ jobs:
CERTIFICATE_SHA1_HASH: ${{ secrets.CODE_SIGNING_CERT_SHA1_HASH }}
CLIENT_CERTIFICATE: ${{ secrets.CODE_SIGNING_CLIENT_CERT }}
CLIENT_CERTIFICATE_PASSWORD: ${{ secrets.CODE_SIGNING_CLIENT_CERT_PASSWORD }}
uses: cognitedata/code-sign-action/@v2.1
uses: cognitedata/code-sign-action/@v2.11
with:
path-to-binary: 'test\test.dll'

Expand All @@ -32,7 +32,7 @@ jobs:
CERTIFICATE_SHA1_HASH: ${{ secrets.CODE_SIGNING_CERT_SHA1_HASH }}
CLIENT_CERTIFICATE: ${{ secrets.CODE_SIGNING_CLIENT_CERT }}
CLIENT_CERTIFICATE_PASSWORD: ${{ secrets.CODE_SIGNING_CLIENT_CERT_PASSWORD }}
uses: cognitedata/code-sign-action/@v2.1
uses: cognitedata/code-sign-action/@v2.11
with:
path-to-binary: 'test\test.dll'

Expand All @@ -49,7 +49,7 @@ jobs:
CERTIFICATE_SHA1_HASH: ${{ secrets.CODE_SIGNING_CERT_SHA1_HASH }}
CLIENT_CERTIFICATE: ${{ secrets.CODE_SIGNING_CLIENT_CERT }}
CLIENT_CERTIFICATE_PASSWORD: ${{ secrets.CODE_SIGNING_CLIENT_CERT_PASSWORD }}
uses: cognitedata/code-sign-action/@v2.1
uses: cognitedata/code-sign-action/@v2.11
with:
path-to-binary: "test/test.dll"

Expand All @@ -60,6 +60,6 @@ jobs:
CERTIFICATE_SHA1_HASH: ${{ secrets.CODE_SIGNING_CERT_SHA1_HASH }}
CLIENT_CERTIFICATE: ${{ secrets.CODE_SIGNING_CLIENT_CERT }}
CLIENT_CERTIFICATE_PASSWORD: ${{ secrets.CODE_SIGNING_CLIENT_CERT_PASSWORD }}
uses: cognitedata/code-sign-action/@v2.1
uses: cognitedata/code-sign-action/@v2.11
with:
path-to-binary: "test/test.dll"
6 changes: 3 additions & 3 deletions action.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -10,13 +10,13 @@ runs:
- name: Setup Certificate Windows
run: |
echo "${{env.CLIENT_CERTIFICATE }}" | base64 --decode > /d/cognite_code_signing_github_actions.p12
if: runner.os == 'Windows' && ${{ env.DEPS_INSTALLED }} != "TRUE"
if: runner.os == 'Windows'
shell: bash

- name: Setup Certificate Linux
run: |
echo "${{env.CLIENT_CERTIFICATE }}" | base64 --decode | sudo install -D /dev/stdin /d/cognite_code_signing_github_actions.p12
if: runner.os == 'Linux' && ${{ env.DEPS_INSTALLED }} != "TRUE"
if: runner.os == 'Linux'
shell: bash

- name: Set variables
Expand All @@ -36,7 +36,7 @@ runs:
echo "/tmp/DigiCert One Signing Manager Tools/smtools-linux-x64" >> $GITHUB_PATH
fi
shell: bash
if: ${{ env.DEPS_INSTALLED }} != "TRUE"
# if: ${{ env.DEPS_INSTALLED }} != "TRUE"

- name: Code signing with Secure Software Manager
uses: digicert/[email protected]
Expand Down

0 comments on commit 2c023b4

Please sign in to comment.