Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid installing everything multiple times #12

Closed
wants to merge 6 commits into from
Closed

Avoid installing everything multiple times #12

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
552f020
Avoid installing everything multiple times
sondresolbakken Aug 29, 2023
f876055
Add new version
sondresolbakken Aug 29, 2023
2c023b4
Remove dependency var check when setting up certificate
bisera-cognite Aug 31, 2023
e327b3a
Add quotes to print envv var
bisera-cognite Aug 31, 2023
06cdbb9
Remove Jsign from Linux
bisera-cognite Sep 5, 2023
78427d7
Remove Jsign from Linux
bisera-cognite Sep 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 23 additions & 25 deletions .github/workflows/run-action.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
name: run-action
on:
pull_request:
push:
branches:
- main
Expand All @@ -9,7 +10,6 @@ on:
jobs:
run-action:
runs-on: windows-2022
environment: CD
steps:
- name: Checkout code
uses: actions/checkout@v3
Expand All @@ -21,25 +21,23 @@ jobs:
CERTIFICATE_SHA1_HASH: ${{ secrets.CODE_SIGNING_CERT_SHA1_HASH }}
CLIENT_CERTIFICATE: ${{ secrets.CODE_SIGNING_CLIENT_CERT }}
CLIENT_CERTIFICATE_PASSWORD: ${{ secrets.CODE_SIGNING_CLIENT_CERT_PASSWORD }}
uses: cognitedata/code-sign-action/@v2
uses: cognitedata/code-sign-action/@v2.14
with:
path-to-binary: 'test\test.dll'

# - name: Run the action for multiple binaries in a directory
# env:
# CERTIFICATE_HOST: ${{ secrets.CODE_SIGNING_CERT_HOST }}
# CERTIFICATE_HOST_API_KEY: ${{ secrets.CODE_SIGNING_CERT_HOST_API_KEY }}
# CERTIFICATE_SHA1_HASH: ${{ secrets.CODE_SIGNING_CERT_SHA1_HASH }}
# CLIENT_CERTIFICATE: ${{ secrets.CODE_SIGNING_CLIENT_CERT }}
# CLIENT_CERTIFICATE_PASSWORD: ${{ secrets.CODE_SIGNING_CLIENT_CERT_PASSWORD }}
# uses: cognitedata/code-sign-action/@v2
# with:
# path-to-binary: 'test'

- name: Run the action for multiple binaries in a directory
env:
CERTIFICATE_HOST: ${{ secrets.CODE_SIGNING_CERT_HOST }}
CERTIFICATE_HOST_API_KEY: ${{ secrets.CODE_SIGNING_CERT_HOST_API_KEY }}
CERTIFICATE_SHA1_HASH: ${{ secrets.CODE_SIGNING_CERT_SHA1_HASH }}
CLIENT_CERTIFICATE: ${{ secrets.CODE_SIGNING_CLIENT_CERT }}
CLIENT_CERTIFICATE_PASSWORD: ${{ secrets.CODE_SIGNING_CLIENT_CERT_PASSWORD }}
uses: cognitedata/code-sign-action/@v2.14
with:
path-to-binary: 'test\test.dll'

run-action-linux:
runs-on: ubuntu-22.04
environment: CD
steps:
- name: Checkout code
uses: actions/checkout@v3
Expand All @@ -51,17 +49,17 @@ jobs:
CERTIFICATE_SHA1_HASH: ${{ secrets.CODE_SIGNING_CERT_SHA1_HASH }}
CLIENT_CERTIFICATE: ${{ secrets.CODE_SIGNING_CLIENT_CERT }}
CLIENT_CERTIFICATE_PASSWORD: ${{ secrets.CODE_SIGNING_CLIENT_CERT_PASSWORD }}
uses: cognitedata/code-sign-action/@v2
uses: cognitedata/code-sign-action/@v2.14
with:
path-to-binary: "test/test.dll"

# - name: Run the action for multiple binaries in a directory
# env:
# CERTIFICATE_HOST: ${{ secrets.CODE_SIGNING_CERT_HOST }}
# CERTIFICATE_HOST_API_KEY: ${{ secrets.CODE_SIGNING_CERT_HOST_API_KEY }}
# CERTIFICATE_SHA1_HASH: ${{ secrets.CODE_SIGNING_CERT_SHA1_HASH }}
# CLIENT_CERTIFICATE: ${{ secrets.CODE_SIGNING_CLIENT_CERT }}
# CLIENT_CERTIFICATE_PASSWORD: ${{ secrets.CODE_SIGNING_CLIENT_CERT_PASSWORD }}
# uses: cognitedata/code-sign-action/@v2
# with:
# path-to-binary: "test"
- name: Run the action for multiple binaries in a directory
env:
CERTIFICATE_HOST: ${{ secrets.CODE_SIGNING_CERT_HOST }}
CERTIFICATE_HOST_API_KEY: ${{ secrets.CODE_SIGNING_CERT_HOST_API_KEY }}
CERTIFICATE_SHA1_HASH: ${{ secrets.CODE_SIGNING_CERT_SHA1_HASH }}
CLIENT_CERTIFICATE: ${{ secrets.CODE_SIGNING_CLIENT_CERT }}
CLIENT_CERTIFICATE_PASSWORD: ${{ secrets.CODE_SIGNING_CLIENT_CERT_PASSWORD }}
uses: cognitedata/code-sign-action/@v2.14
with:
path-to-binary: "test/test.dll"
11 changes: 8 additions & 3 deletions action.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,15 +66,20 @@ runs:
if: runner.os == 'Windows'
shell: powershell


- name: Sign with smctl Linux
run: |
curl -fSslL https://github.com/ebourg/jsign/releases/download/3.1/jsign_3.1_all.deb -o jsign_3.1_all.deb
sudo dpkg --install jsign_3.1_all.deb
file_path="${{ inputs.path-to-binary }}"
for f in $(find $file_path -type f); do
echo $f
smctl sign -v --keypair-alias="key_464138416" --config-file="/tmp/DigiCert One Signing Manager Tools/smtools-linux-x64/pkcs11properties.cfg" --fingerprint "${{ env.SM_CODE_SIGNING_CERT_SHA1_HASH }}" --input "$f"
done
if: runner.os == 'Linux'
shell: bash

# - name: Set dependency envar
# id: dep-var
# run: |
# echo "$DEPS_INSTALLED"
# echo "DEPS_INSTALLED=TRUE" >> "$GITHUB_ENV"
# echo "$DEPS_INSTALLED"
# shell: bash
Loading