-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SEC-2913] Update action to fit the new code signing flow #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sondresolbakken
approved these changes
Aug 7, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
bisera-cognite
changed the title
Trigger code signing action
[SEC-2913] Update action to fit the new code signing flow
Aug 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
With the new code signing certificate issued by Digicert, the way a certificate is being stored has changed. This affects the flow of acquiring the certificate to be able to perform the signing.
Changes
digicert/[email protected]
to set up the runner environment for code signing.CODE_SIGNING_CERT_HOST
,CODE_SIGNING_CERT_HOST_API_KEY
,CODE_SIGNING_CERT_SHA1_HASH
,CODE_SIGNING_CLIENT_CERT
,CODE_SIGNING_CLIENT_CERT_PASSWORD
.-Recurse
option because it is not needed anymore for recursive signing.v2
.