Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SEC-2913] Update action to fit the new code signing flow #8

Merged
merged 165 commits into from
Aug 7, 2023

Conversation

admin-bisera-cognite
Copy link
Contributor

@admin-bisera-cognite admin-bisera-cognite commented Aug 1, 2023

Background

With the new code signing certificate issued by Digicert, the way a certificate is being stored has changed. This affects the flow of acquiring the certificate to be able to perform the signing.

Changes

  • New certificate issued.
  • Connect to Digicert One platform to fetch the certificate necessary for signing. This composite action uses digicert/[email protected] to set up the runner environment for code signing.
  • The list of required secrets has changed to: CODE_SIGNING_CERT_HOST, CODE_SIGNING_CERT_HOST_API_KEY, CODE_SIGNING_CERT_SHA1_HASH, CODE_SIGNING_CLIENT_CERT, CODE_SIGNING_CLIENT_CERT_PASSWORD.
  • Removed -Recurse option because it is not needed anymore for recursive signing.
  • Updated documentation to reflect the use of the new action version v2.

@bisera-cognite bisera-cognite requested a review from a team as a code owner August 1, 2023 11:25
Copy link
Contributor

@sondresolbakken sondresolbakken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bisera-cognite bisera-cognite merged commit fad1c3d into main Aug 7, 2023
2 checks passed
@bisera-cognite bisera-cognite deleted the test-new-code-signing-cert branch August 7, 2023 13:01
@bisera-cognite bisera-cognite changed the title Trigger code signing action [SEC-2913] Update action to fit the new code signing flow Aug 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants