[v7] Fix exceptions not being raised together as CogniteMultiException
#1456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## v7-release #1456 +/- ##
=============================================
Coverage ? 91.80%
=============================================
Files ? 121
Lines ? 15182
Branches ? 0
=============================================
Hits ? 13938
Misses ? 1244
Partials ? 0 |
haakonvt
changed the title
CogniteMultiExceptionCogniteMultiException
haakonvt
force-pushed
the
fix-exceptions
branch
from
7572e20
to
025b6f2
Compare
4 tasks
haakonvt
force-pushed
the
fix-exceptions
branch
from
025b6f2
to
776ea55
Compare
doctrino
approved these changes
Nov 1, 2023
| @@ -236,7 +236,7 @@ def __str__(self) -> str: | |||
| return msg | |||
|
|
|||
|
|
|||
| class CogniteImportError(CogniteException): | |||
| class CogniteImportError(CogniteException, ImportError): | |||
Yes 🤩 I have no idea why someone started raising the first reception 🤷 My guess is that it was an error - and lots of people then copied it... |
haakonvt
force-pushed
the
fix-exceptions
branch
from
2473a1f
to
db9b1a1
Compare
haakonvt
added a commit
that referenced
this pull request
Nov 1, 2023
haakonvt
added a commit
that referenced
this pull request
Nov 3, 2023
haakonvt
added a commit
that referenced
this pull request
Nov 3, 2023
doctrino
pushed a commit
that referenced
this pull request
Nov 8, 2023
haakonvt
added a commit
that referenced
this pull request
Nov 8, 2023
haakonvt
added a commit
that referenced
this pull request
Nov 10, 2023
haakonvt
added a commit
that referenced
this pull request
Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes one of the oldest issues: #578
With this change,
client.time_series.data.retrieve_latest(id=123), assuming this id doesn't randomly exist, now raisesCogniteNotFoundErrorinstead ofCogniteAPIError.