Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retry context diagram endpoints #1990

Merged
merged 7 commits into from
Oct 26, 2024
Merged

Retry context diagram endpoints #1990

merged 7 commits into from
Oct 26, 2024

Conversation

doctrino
Copy link
Contributor

Description

Please describe the change you have made.

Checklist:

  • Tests added/updated.
  • Documentation updated. Documentation is generated from docstrings - these must be updated according to your change.
    If a new method has been added it should be referenced in cognite.rst in order to generate docs based on its docstring.
  • Changelog updated in CHANGELOG.md.
  • Version bumped. If triggering a new release is desired, bump the version number in _version.py and pyproject.toml per semantic versioning.

@doctrino doctrino requested review from a team as code owners October 22, 2024 05:44
Copy link

codecov bot commented Oct 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.21%. Comparing base (b5213d4) to head (27de6ad).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1990      +/-   ##
==========================================
+ Coverage   90.19%   90.21%   +0.01%     
==========================================
  Files         139      139              
  Lines       21772    21772              
==========================================
+ Hits        19638    19641       +3     
+ Misses       2134     2131       -3     
Files with missing lines Coverage Δ
cognite/client/_api_client.py 90.11% <ø> (ø)
cognite/client/_version.py 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

Copy link
Contributor

@haakonvt haakonvt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a test 👌

@@ -103,6 +103,7 @@ class APIClient:
"workflows/.*",
"hostedextractors/.*",
"postgresgateway/.*",
"context/diagram/*",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing a dot I believe

tests/tests_unit/test_api_client.py Outdated Show resolved Hide resolved
@doctrino doctrino enabled auto-merge (squash) October 26, 2024 17:36
@doctrino doctrino merged commit 9cb61f8 into master Oct 26, 2024
16 checks passed
@doctrino doctrino deleted the retry-detect-endpoints branch October 26, 2024 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants