Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: limit=0 yields self._LIST_LIMIT instead of raising APIError #788

Closed
wants to merge 2 commits into from
Closed

Bug: limit=0 yields self._LIST_LIMIT instead of raising APIError #788

wants to merge 2 commits into from

Conversation

qTipTip
Copy link
Contributor

@qTipTip qTipTip commented Feb 22, 2021 •
edited by erlendvollset
Loading

Setting limit=0 in the _list-method incorrectly returns self._LIST_LIMIT number of items. It should raise an APIError as limit>0 is enforced in context-api.

Addresses #789

@erlendvollset erlendvollset linked an issue Feb 22, 2021 that may be closed by this pull request
limit=0 yields self._LIST_LIMIT instead of raising APIError #789
Open
@qTipTip qTipTip closed this Mar 4, 2021
@erlendvollset erlendvollset deleted the zero-limit-fix branch October 1, 2022 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

limit=0 yields self._LIST_LIMIT instead of raising APIError
1 participant
@qTipTip