[NEAT-874] 🔨 Interface for state #1077
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
☂️ Python Coverage
Overall Coverage
New Files
Modified Files
|
doctrino
force-pushed
the
introduce-neat-state
branch
from
e5c8807 to
6d56817
Compare
doctrino
force-pushed
the
introduce-neat-state
branch
from
7c4629f to
8401a25
Compare
nikokaoja
reviewed
Apr 2, 2025
cognite/neat/_state/_state.py
Outdated
| raise NotImplementedError() | ||
|
|
||
| @abstractmethod | ||
| def next_state(self, action: Action) -> "State": |
There was a problem hiding this comment.
Next state is telling you what is possible next state or ?
There was a problem hiding this comment.
No, it is transitioning to the next state.
doctrino
added a commit
that referenced
this pull request
Apr 7, 2025
# Description This is part of a refactoring to NeatState, #1077. This modifies the `.transform()` method of `NeatGraphStore` to return an `IssueList`. The motivation for this is that this should comply with the other action methods `NeatRuleStore.import_rules/transform()` and `NeatGraphStore.write` that already return an `IssueList`. In addition, it now returns an error if the graph transformation failed. This is important as a failed transformation execution should not lead to a state change. ## Bump - [ ] Patch - [ ] Minor - [x] Skip
nikokaoja
approved these changes
Apr 24, 2025
doctrino
added
the
waiting-for-risk-review
nikokaoja
requested changes
Apr 25, 2025
nikokaoja
reviewed
Apr 25, 2025
| """Returns the display name of the current state.""" | ||
| return self._state.display_name | ||
|
|
||
| def change(self, action: Action) -> IssueList: |
There was a problem hiding this comment.
This is change in terms of what we define as change in Provenance, therefore, your argument is not action, but Agent (extractor, loader, transformer) that is configured to perform certain Activity, so this should be called activity not action
doctrino
removed
the
waiting-for-risk-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Context: This is the first in a series of planned PRs. It is currently unused code as it is not yet complete.
Overall goal: The
NeatSessionis one of two planned user interfaces. Currently, there is some logic in the interface that needs to be moved out. The most significant logic is the state that guards the state transitions. Through a series of PRs the goal is to replace the NeatSession state with this NeatState.This PR: Creates the scaffolding for the new
NeatStateclass. In addition, I have implemented a state pattern to guard the transition between four states with basic testing.Bump