-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(react-components): react components rule core improvements to fix several issues in the Rule Builder time series selection/searching/selecting/filtering #4805
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine - a few comments
react-components/src/components/RuleBasedOutputs/utils/getResourceRelationship.ts
Outdated
Show resolved
Hide resolved
react-components/src/components/RuleBasedOutputs/utils/getResourceRelationship.ts
Outdated
Show resolved
Hide resolved
…ithout-timeseries-for-empty-query
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
react-components/src/hooks/useFetchTimeseriesResourceRelationship.ts
Outdated
Show resolved
Hide resolved
…r-assets-without-timeseries-for-empty-query' into danpriori/BND3D-4356-rule-builder-assets-without-timeseries-for-empty-query
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about tests? Is there some simple mock data we could create to make this testable?
react-components/src/query/useFetchTimeseriesResourceRelationship.ts
Outdated
Show resolved
Hide resolved
… assets and relationships then
… fetching relationships
…ithout-timeseries-for-empty-query
…r-assets-without-timeseries-for-empty-query' into danpriori/BND3D-4356-rule-builder-assets-without-timeseries-for-empty-query
…ithout-timeseries-for-empty-query
…ithout-timeseries-for-empty-query
…ithout-timeseries-for-empty-query
…ithout-timeseries-for-empty-query
Type of change
Description 📝
This PR is bundled with PR: https://github.com/cognitedata/fusion/pull/8742 to fix several bugs related to fetching assets with timeseries, filtering timeseries types and selecting within the Rule Builder in 3d-management.
This PR specifically exposes some updated types, performs parallel timeseries fetching in functions and hooks, and other related improvements.
rulebuilder-timeseries.webm
rulebuilder-timeseries2.webm
Checklist ☑️