Updated with changes from original code base, fully migrated to react-router-dom-v5-compat #358
Conversation
| @@ -19,7 +20,8 @@ export const CommandersList = () => { | |||
| }>(); | |||
|
|
|||
| useEffect(() => { | |||
| document.title = `${commanderBase} - ${capitalize(race)}`; | |||
There was a problem hiding this comment.
Is there any reason for this change?
There was a problem hiding this comment.
I had issues with the capitalize during the migration. If the original line is kept, I would face this error.
There was a problem hiding this comment.
I see, you can fix this by passing there empty string like this ${capitalize(race || "")}
|
Hi @auan369 it looks like there is some issue, it doesn't load for me
|
|
Tr
Trying it out on my side again and I have the same issue now as well. Seems like issue with Link in main-header.tsx and main-footer.tsx still persists. Changing the import to |
|
Hi @petrvecera , I have discovered the issue with the Links. The update is to shift the CompatRouter component the above MainHeader and MainFooter components. Then we can use react-router-dom-v5-compat for all files. |
Nice, can you push this change? 👍 |
|
Just sent the PR 👍 |
|
closing this in favor of #359 FYI: you can always just update the original branch, no need to create a new one, you can also always do git push --force to force the change in the commits |
Have included the most recent commits to the original code base and have migrated fully to react-router-dom-v5-compat