Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests and refactor #73

Merged
merged 1 commit into from
Mar 1, 2024
Merged

Add tests and refactor #73

merged 1 commit into from
Mar 1, 2024

Conversation

petrvecera
Copy link
Member

@petrvecera petrvecera commented Mar 1, 2024

Adding tests and various refactors

@petrvecera petrvecera requested a review from ryantaylor March 1, 2024 09:11
@@ -76,6 +76,12 @@ jobs:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
TAURI_PRIVATE_KEY: ${{ secrets.TAURI_PRIVATE_KEY }}
TAURI_KEY_PASSWORD: ${{ secrets.TAURI_KEY_PASSWORD }}

- name: Run Rust tests
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd recommend adding check, fmt, and clippy here as well for some general linting of the Rust code. There's an example of the setup here: https://github.com/ryantaylor/vault/blob/master/.github/workflows/checks.yml

Copy link
Member Author

@petrvecera petrvecera Mar 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reported as #74

error!("Couldn't start the streamer overlay server: {:?}", err);
}

return;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not necessary to do here I'd say, but it probably makes sense to find all the error! log calls and send them to your monitoring tool too eventually.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep 👍

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#75

@petrvecera petrvecera merged commit a11970e into master Mar 1, 2024
2 checks passed
@petrvecera petrvecera deleted the add-test-refactor branch March 1, 2024 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants