Test ddf isin with large list #414
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ncclementi
reviewed
Oct 3, 2022
ncclementi
reviewed
Oct 6, 2022
tests/benchmarks/test_dataframe.py
Outdated
| ddf = timeseries(end="2000-05-01", dtypes={"A": float, "B": int}, seed=42) | ||
| ddf.A = ddf.A.mul(1e7) | ||
| ddf.A = ddf.A.astype(int).persist() | ||
| a_column_unique_values = np.arange(1, n // 10) |
There was a problem hiding this comment.
nitpick, it looks like we only use n once, do we need to create a variable (line 71), is this a number that could potentially change? Or did we choose this number arbitrarily?
There was a problem hiding this comment.
Cleared up by algning 1e7 to N. Yes the value could change.
tests/benchmarks/test_dataframe.py
Outdated
| n = 10_000_000 | ||
| rs = np.random.RandomState(42) | ||
| ddf = timeseries(end="2000-05-01", dtypes={"A": float, "B": int}, seed=42) | ||
| ddf.A = ddf.A.mul(1e7) |
There was a problem hiding this comment.
It might be worth a comment here on why we need these next two lines. Is it a cardinality issue?
|
Thanks, @hayesgb ! |
|
I'll merge main and uncomment the test.yaml code |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a test for filtering a dataframe by columns on a large list