Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pytorch environment for package sync #48

Merged
merged 2 commits into from
May 16, 2024
Merged

Conversation

jrbourbeau
Copy link
Member

These are reasonable changes to make anyways, but I noticed this also fixes the package sync problem @scharlottej13 reported offline. @scharlottej13 can you see if the pytorch notebook now works for you?

To be clear, I don't understand why this fixes things, but it seems to. We should figure out the issue folks are running into, but the changes here seem fine regardless.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@ntabris
Copy link
Member

ntabris commented May 16, 2024

As in switching py3.10 to py3.11 fixes this?

@jrbourbeau
Copy link
Member Author

Either that or dropping pynvml (which we automatically add now). I've not tried to reproduce the problem @scharlottej13 reported though on main.

@scharlottej13
Copy link
Contributor

Thanks @jrbourbeau! Linking to the slack thread too: https://coiledcomputing.slack.com/archives/C064FUMHTSB/p1715887638735399

Confirming this solves my problem! Adding nvidia as a channel worked too.

@jrbourbeau
Copy link
Member Author

Confirming this solves my problem!

🎉 🤷

@jrbourbeau jrbourbeau merged commit d925e94 into main May 16, 2024
3 checks passed
@jrbourbeau jrbourbeau deleted the fix-pytorch-env branch May 16, 2024 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants