Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use always 64-bit arithemtics #112

Merged
merged 1 commit into from
Feb 13, 2025
Merged

Conversation

christoph-cullmann
Copy link
Contributor

long is only 32-bit on 32-bit systems and on 64-bit Windows ensure we have consistent behavior

@christoph-cullmann
Copy link
Contributor Author

Follow up of

coin-or/CoinUtils#245

See coin-or/Cbc#690

@jjhforrest

long is only 32-bit on 32-bit systems and on 64-bit Windows
ensure we have consistent behavior
@christoph-cullmann
Copy link
Contributor Author

christoph-cullmann commented Feb 13, 2025

Missed the labs vs. llabs.

@christoph-cullmann
Copy link
Contributor Author

Seems I messed up the gomory change, just the src/CglPreProcess/CglPreProcess.cpp is needed to fix the bug, the other locations just look as wrong for large numbers and the USE_CGL_RATIONAL==0 path with the

typedef struct {
  int numerator;
  int denominator;
} Rational;

looks strange for me.

@jjhforrest jjhforrest merged commit 1b05b84 into coin-or:master Feb 13, 2025
1 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants