-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Improve ability to distinguish between networks, assets, and trade types #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…vs non-WOW trades - Formatted prompts for better legibility - Fixed issue whereby chatbot didn't know what network it was on by default - Added chatbot to local lib workspace for easier local development
cdp-agentkit-core/src/actions/cdp/defi/wow/actions/create_token.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These look reasonable. Please update CHANGELOG.md
's
- Remove chatbot example from workspace - Add 'bonding curve token' to prompts for WOW actions
- Remove chatbot example from workspace - Add 'bonding curve token' to prompts for WOW actions
derek-cb
commented
Dec 6, 2024
@@ -1,5 +1,6 @@ | |||
{ | |||
"name": "cdp-agentkit-monorepo", | |||
"private": true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added this to prevent accidental publishing of the root-level package
John-peterson-coinbase
approved these changes
Dec 6, 2024
stat
pushed a commit
that referenced
this pull request
Dec 6, 2024
…ade types (#19) * - Improved prompts for CDP actions (more specificity surrounding WOW vs non-WOW trades - Formatted prompts for better legibility - Fixed issue whereby chatbot didn't know what network it was on by default - Added chatbot to local lib workspace for easier local development * Changelog update * Added chatbot changelog, updated cdp-langchain changelog * Remove unnecessary import from root-level package.json * No need to increment chatbot version (not publishing at the moment) * Implementing feedback: - Remove chatbot example from workspace - Add 'bonding curve token' to prompts for WOW actions * Implementing feedback: - Remove chatbot example from workspace - Add 'bonding curve token' to prompts for WOW actions * Stripping out AgentKit version upgrades * Revert chatbot package-lock.json
stat
pushed a commit
that referenced
this pull request
Dec 6, 2024
…ade types (#19) * - Improved prompts for CDP actions (more specificity surrounding WOW vs non-WOW trades - Formatted prompts for better legibility - Fixed issue whereby chatbot didn't know what network it was on by default - Added chatbot to local lib workspace for easier local development * Changelog update * Added chatbot changelog, updated cdp-langchain changelog * Remove unnecessary import from root-level package.json * No need to increment chatbot version (not publishing at the moment) * Implementing feedback: - Remove chatbot example from workspace - Add 'bonding curve token' to prompts for WOW actions * Implementing feedback: - Remove chatbot example from workspace - Add 'bonding curve token' to prompts for WOW actions * Stripping out AgentKit version upgrades * Revert chatbot package-lock.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why?
Improved the agent's ability to recognize assets (ie, USDC, DAI) without further prompting in specific cases whereby network was not explicitly queried beforehand by the agent. Also better ability to distinguish between WOW and non-WOW type asset trading.
Qualified Impact