refactor: use ZodString.min(1) instead of deprecated ZodString.nonempty()
#33
+13
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roushou
changed the title
ZodString.min(1) instead of deprecated ZodString.nonempty()ZodString.min(1) instead of deprecated ZodString.nonempty()
|
Thanks for the update @roushou ! Can you please add a line item under Unreleased in We will be happy to accept this. |
roushou
force-pushed
the
fix-deprecated-string-nonempty
branch
from
1be5b51 to
6857a14
Compare
|
Thanks! Updated @John-peterson-coinbase |
John-peterson-coinbase
approved these changes
Dec 16, 2024
|
@roushou - We require all commits to be signed. Please follow Learn more about signing commits. to set up GPG commit signing and rebase with signed commits please. |
…empty()` chore: update CHANGELOG
roushou
force-pushed
the
fix-deprecated-string-nonempty
branch
from
6857a14 to
759166e
Compare
|
Should be good now @John-peterson-coinbase |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why?
Hello,
ZodString.nonempty()is deprecated since awhile as per this discussion colinhacks/zod#2847 andZodString.min(1)should be used instead.It also pops up on the LSP.
So this PR basically replaces all
nonempty()bymin(1)and still preserves error initial error messages.