feat: Support Register/List/Update Smart Contract

[jianlunz-cb]

What changed? Why?

Support Register/List/Update Smart Contract

Test:

>>> SmartContract.register(contract_name="Test Contract", contract_address="0x0000000071727de22e5e9d8baf0edac6f37da040", network_id="base-sepolia", abi=[
...   {
...     "constant": True,
...     "name": "myField",
...     "outputs": [
...       {
...         "name": "",
...         "type": "uint256"
...       }
...     ],
...     "type": "function"
...   }
... ])

CDP API RESPONSE: Status: 200, Data: b'{"abi":"[{\\"constant\\":true,\\"name\\":\\"myField\\",\\"outputs\\":[{\\"name\\":\\"\\",\\"type\\":\\"uint256\\"}],\\"type\\":\\"function\\"}]","contract_address":"0x0000000071727De22e5E9d8bAF0EDaC6f37Da040","contract_name":"Test Contract","is_external":true,"network_id":"base-sepolia","smart_contract_id":"0104b87a-6617-45f4-924f-06b26e21d77e","type":"custom"}\n'
SmartContract: (smart_contract_id: 0104b87a-6617-45f4-924f-06b26e21d77e, wallet_id: None, network_id: base-sepolia, contract_address: 0x0000000071727De22e5E9d8bAF0EDaC6f37Da040, type: custom, transaction_hash: None, transaction_link: None, status: None)

>>> SmartContract.update(contract_name="Updated Test Contract", contract_address="0x0000000071727de22e5e9d8baf0edac6f37da040", network_id="base-sepolia", abi=[
...   {
...     "constant": False,
...     "name": "newField",
...     "outputs": [
...       {
...         "name": "",
...         "type": "uint256"
...       }
...     ],
...     "type": "function"
...   }
... ])

CDP API RESPONSE: Status: 200, Data: b'{"abi":"[{\\"constant\\":false,\\"name\\":\\"newField\\",\\"outputs\\":[{\\"name\\":\\"\\",\\"type\\":\\"uint256\\"}],\\"type\\":\\"function\\"}]","contract_address":"0x0000000071727De22e5E9d8bAF0EDaC6f37Da040","contract_name":"Updated Test Contract","is_external":true,"network_id":"base-sepolia","smart_contract_id":"0104b87a-6617-45f4-924f-06b26e21d77e","type":"custom"}\n'
SmartContract: (smart_contract_id: 0104b87a-6617-45f4-924f-06b26e21d77e, wallet_id: None, network_id: base-sepolia, contract_address: 0x0000000071727De22e5E9d8bAF0EDaC6f37Da040, type: custom, transaction_hash: None, transaction_link: None, status: None)

>>> l = SmartContract.list()
>>> for sc in l:
...      print(sc)

{"abi":"[{\\"constant\\":false,\\"name\\":\\"newField\\",\\"outputs\\":[{\\"name\\":\\"\\",\\"type\\":\\"uint256\\"}],\\"type\\":\\"function\\"}]","contract_address":"0x0000000071727de22e5e9d8baf0edac6f37da040","contract_name":"Updated Test Contract","is_external":false,"network_id":"base-sepolia","smart_contract_id":"","type":"custom"}
SmartContract: (smart_contract_id: , wallet_id: None, network_id: base-sepolia, contract_address: 0x0000000071727de22e5e9d8baf0edac6f37da040, type: custom, transaction_hash: None, transaction_link: None, status: None)

Qualified Impact

[cb-heimdall]

🟡 Heimdall Review Status

Requirement	Status	More Info
Reviews	🟡 0/1	Denominator calculation Show calculation 1 if user is bot 0 1 if user is external 0 From .codeflow.yml 1 Additional review requirements Show calculation Max 0 0 From CODEOWNERS 0 Global minimum 0 Max 1 1 1 if commit is unverified 1 Sum 2

[alex-stone]

This should return a boolean

[jianlunz-cb]

Good catch updated

[alex-stone]

I think now a lot of these other properties will be only set if is_external is false.

This is the NodeJS change we had to make to support this:
coinbase/coinbase-sdk-nodejs@94680a6#diff-2c6bead48767df9b8a842ac4887f9e676b0b38a3b6fc2c4bdb7ff6e2d9ddbb7dR227

[jianlunz-cb]

I added a check of the external fields before returning. If it looks good I'll apply it to the nodejs change

[alex-stone]

If it looks good I'll apply it to the nodejs change

I just linked the change that was made to the NodeJS to handle this!

[alex-stone]

We'll also want to handle #sign, #wait, #broadcast, etc... to ensure they throw appropriate errors when called on external contracts

[jianlunz-cb]

Gotcha, updated! Thank you

[alex-stone]

Can you make sure your commits are getting verified?

You may need git config scoped to this repo that includes your specific external GitHub username + signing key configuration

[John-peterson-coinbase]

Please rebase down to only verified commits