Skip to content

Commit

Permalink
updated github action cache value
Browse files Browse the repository at this point in the history
Signed-off-by: Giuseppe Macri <[email protected]>
  • Loading branch information
giuseppe-coinbase committed Dec 7, 2023
1 parent 007ab35 commit 30ddeab
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 1 deletion.
2 changes: 1 addition & 1 deletion .github/actions/setup/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ jobs:
uses: actions/setup-node@v3
with:
node-version: ${{ matrix.node-version }}
cache: 'yarn'
cache: 'npm'
- name: Install dependencies
run: yarn install
- name: Format Check
Expand Down
1 change: 1 addition & 0 deletions .github/pull_request_template.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ If this PR is a work in progress, please prefix the title with [WIP].
- [] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [] Refactor (refactoring production code or docs)
- [] Test (adding missing tests or fixing existing tests)
- [] Chore (updating yarn tasks etc; no production code change)
- [] Other (please describe):

## Checklist
Expand Down
1 change: 1 addition & 0 deletions src/utils/perfume.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -611,6 +611,7 @@ describe('perfume', () => {
test('should call markNTBT() when platform is web', () => {
initPerfMonitoring();
// eslint-disable-next-line @typescript-eslint/no-unused-expressions
// TODO: if we don't passe the mock NTBT we can't really test it
// perfumeInstance ? (perfumeInstance.markNTBT = mockMarkNTBT) : null;
markNTBT();
expect(mockMarkNTBT).toHaveBeenCalled();
Expand Down

0 comments on commit 30ddeab

Please sign in to comment.