updated github action cache value

Signed-off-by: Giuseppe Macri <[email protected]>
coinbase · Dec 7, 2023 · 61b4fb6 · 61b4fb6
1 parent 007ab35
commit 61b4fb6
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/.github/actions/setup/action.yml b/.github/actions/setup/action.yml
@@ -21,7 +21,7 @@ jobs:
         uses: actions/setup-node@v3
         with:
           node-version: ${{ matrix.node-version }}
-          cache: 'yarn'
+          cache: 'npm'
       - name: Install dependencies
         run: yarn install
       - name: Format Check

diff --git a/src/utils/perfume.test.ts b/src/utils/perfume.test.ts
@@ -611,6 +611,7 @@ describe('perfume', () => {
     test('should call markNTBT() when platform is web', () => {
       initPerfMonitoring();
       // eslint-disable-next-line @typescript-eslint/no-unused-expressions
+      // TODO: if we don't passe the mock NTBT we can't really test it
       // perfumeInstance ? (perfumeInstance.markNTBT = mockMarkNTBT) : null;
       markNTBT();
       expect(mockMarkNTBT).toHaveBeenCalled();