Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Fixed metric payload, updated github actions and tests #29

Merged
merged 6 commits into from
Dec 18, 2023

Conversation

giuseppe-coinbase
Copy link
Contributor

@giuseppe-coinbase giuseppe-coinbase commented Dec 16, 2023

Description

  • Updated github actions and husky pre commit/fetch scripts.
  • Fixed location tests
  • Fixed metric payload from metricData to metrics
    image

Type of change

  • [] Bug fix (non-breaking change which fixes an issue)
  • [] New feature (non-breaking change which adds functionality)
  • [] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [] Refactor (refactoring production code or docs)
  • Test (adding missing tests or fixing existing tests)
  • Chore (updating yarn tasks etc; no production code change)
  • [] Other (please describe):

Checklist

  • [] unit tests

Update example files

If you have updated the example files, please provide a screenshot of the changes (if appropriate).

Copy link

changeset-bot bot commented Dec 16, 2023

🦋 Changeset detected

Latest commit: 6820320

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
client-analytics Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Signed-off-by: Giuseppe Macri <[email protected]>
Signed-off-by: Giuseppe Macri <[email protected]>
Signed-off-by: Giuseppe Macri <[email protected]>
Signed-off-by: Giuseppe Macri <[email protected]>
@giuseppe-coinbase giuseppe-coinbase changed the title [chore] updated github actions [Bug] Fixed metric payload, updated github actions and tests Dec 16, 2023
Signed-off-by: Giuseppe Macri <[email protected]>
Signed-off-by: Giuseppe Macri <[email protected]>
@cb-heimdall cb-heimdall dismissed cooperwilletts-cb’s stale review December 18, 2023 14:30

Approved review 1785240327 from cooperwilletts-cb is now dismissed due to new commit. Re-request for approval.

@giuseppe-coinbase giuseppe-coinbase merged commit e332706 into master Dec 18, 2023
5 checks passed
@giuseppe-coinbase giuseppe-coinbase deleted the update_github_actions branch December 18, 2023 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants