Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds feature to disable event and/or metric tracking #36

Merged
merged 5 commits into from
Feb 12, 2024

Conversation

shedonnatnael-cb
Copy link
Contributor

@shedonnatnael-cb shedonnatnael-cb commented Feb 11, 2024

Description

Added a couple parameters to the config, disableEventApi and disableMetricApi, that enable developers to cancel trackEvent or trackMetric calls before they send data.

Type of change

  • [] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • [] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [] Refactor (refactoring production code or docs)
  • [] Test (adding missing tests or fixing existing tests)
  • [] Chore (updating yarn tasks etc; no production code change)
  • [] Other (please describe):

Checklist

  • unit tests

Update example files

If you have updated the example files, please provide a screenshot of the changes (if appropriate).

Copy link

changeset-bot bot commented Feb 11, 2024

🦋 Changeset detected

Latest commit: e65caf8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
client-analytics Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@shedonnatnael-cb shedonnatnael-cb changed the title add disable api feature to event/metric tracking Adds feature to disable event and/or metric tracking Feb 12, 2024
@shedonnatnael-cb shedonnatnael-cb marked this pull request as ready for review February 12, 2024 14:47
@shedonnatnael-cb shedonnatnael-cb force-pushed the snatnael/disable-api-feature branch from 99f33a1 to 93f1b2d Compare February 12, 2024 14:57
CHANGELOG.md Outdated Show resolved Hide resolved
@cb-heimdall
Copy link

Review Error for giuseppe-coinbase @ 2024-02-12 17:17:43 UTC
User failed mfa authentication, public email is not set on your github profile. see go/mfa-help

@cb-heimdall
Copy link

Review Error for giuseppe-coinbase @ 2024-02-12 17:17:56 UTC
User failed mfa authentication, public email is not set on your github profile. see go/mfa-help

@shedonnatnael-cb shedonnatnael-cb merged commit c861a15 into master Feb 12, 2024
5 checks passed
@shedonnatnael-cb shedonnatnael-cb deleted the snatnael/disable-api-feature branch February 12, 2024 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants