Merge pull request #19 from coinbase/chore/fix-staking-operation-reload

Only ingest new transactions if they are different

pkg/coinbase/staking_operation.go

@@ -233,7 +233,7 @@ func (c *Client) Wait(ctx context.Context, stakingOperation *StakingOperation, o
 	return stakingOperation, fmt.Errorf("staking operation timed out")
 }
 
-// FetchExternalStakingOperation loads a staking operation from the API associated
+// FetchExternalStakingOperation reloads a staking operation from the API associated
 // with an address.
 func (c *Client) fetchExternalStakingOperation(ctx context.Context, stakingOperation *StakingOperation) (*StakingOperation, error) {
 	so, httpRes, err := c.client.StakeAPI.GetExternalStakingOperation(
@@ -250,7 +250,26 @@ func (c *Client) fetchExternalStakingOperation(ctx context.Context, stakingOpera
 		return nil, fmt.Errorf("failed to fetch staking operation: %s", httpRes.Status)
 	}
 
-	return newStakingOperationFromModel(so)
+	stakingOperation.model = so
+	for _, tx := range so.Transactions {
+		if !stakingOperation.hasTransactionByUnsignedPayload(tx.UnsignedPayload) {
+			newTx, err := newTransactionFromModel(&tx)
+			if err != nil {
+				return nil, err
+			}
+			stakingOperation.transactions = append(stakingOperation.transactions, newTx)
+		}
+	}
+	return stakingOperation, nil
+}
+
+func (s *StakingOperation) hasTransactionByUnsignedPayload(unsignedPayload string) bool {
+	for _, tx := range s.Transactions() {
+		if tx.UnsignedPayload() == unsignedPayload {
+			return true
+		}
+	}
+	return false
 }
 
 func (s *StakingOperation) isTerminalState() bool {

pkg/coinbase/staking_operation_test.go

@@ -8,8 +8,10 @@ import (
 
 	api "github.com/coinbase/coinbase-sdk-go/gen/client"
 	"github.com/coinbase/coinbase-sdk-go/pkg/mocks"
+	"github.com/ethereum/go-ethereum/crypto"
 	"github.com/stretchr/testify/assert"
 	"github.com/stretchr/testify/mock"
+	"github.com/stretchr/testify/require"
 )
 
 func TestStakingOperation_Wait_Success(t *testing.T) {
@@ -26,11 +28,18 @@ func TestStakingOperation_Wait_Success(t *testing.T) {
 	}
 
 	so, err := mockStakingOperation(t, "pending")
-	assert.NoError(t, err, "staking operation creation should not error")
+	require.NoError(t, err, "failed to create staking operation")
+	key, err := crypto.GenerateKey()
+	require.NoError(t, err, "failed to generate ecdsa key")
+	err = so.Sign(key)
+	require.NoError(t, err, "failed to sign staking operation")
+	signedPayload := so.Transactions()[0].SignedPayload()
+	require.NotEmpty(t, signedPayload, "signed payload should not be empty")
 	so, err = c.Wait(context.Background(), so)
 	assert.NoError(t, err, "staking operation wait should not error")
 	assert.Equal(t, "complete", so.Status(), "staking operation status should be complete")
-	assert.Equal(t, len(so.Transactions()), 1, "staking operation should have 1 transaction")
+	assert.Equal(t, 1, len(so.Transactions()), "staking operation should have 1 transaction")
+	assert.Equal(t, signedPayload, so.Transactions()[0].SignedPayload(), "staking operation signed payload should not have changed")
 }
 
 func TestStakingOperation_Wait_Success_CustomOptions(t *testing.T) {
@@ -56,7 +65,7 @@ func TestStakingOperation_Wait_Success_CustomOptions(t *testing.T) {
 	)
 	assert.NoError(t, err, "staking operation wait should not error")
 	assert.Equal(t, "complete", so.Status(), "staking operation status should be complete")
-	assert.Equal(t, len(so.Transactions()), 1, "staking operation should have 1 transaction")
+	assert.Equal(t, 1, len(so.Transactions()), "staking operation should have 1 transaction")
 }
 
 func TestStakingOperation_Wait_Failure(t *testing.T) {