Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better error handling between SDK and API #45

Merged
merged 1 commit into from
Dec 2, 2024
Merged

Better error handling between SDK and API #45

merged 1 commit into from
Dec 2, 2024

Conversation

drohit-cb
Copy link
Contributor

What changed? Why?

This PR helps:

  1. Fix an edge case in error handling preventing real API errors from bubbling up.
  2. Add WithIntegratorContractAddress to allow for setting an explicit integrator contract address for Shared ETH staking.

Qualified Impact

@drohit-cb drohit-cb changed the title Better error handling between SDK and API. Better error handling between SDK and API Dec 2, 2024
@cb-heimdall
Copy link

cb-heimdall commented Dec 2, 2024 •
edited
Loading

✅ Heimdall Review Status

Requirement Status More Info
Reviews ✅ 1/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@drohit-cb drohit-cb marked this pull request as ready for review December 2, 2024 22:38
@drohit-cb drohit-cb merged commit 88b4973 into master Dec 2, 2024
5 checks passed
@drohit-cb drohit-cb deleted the feat/staking-updates branch December 2, 2024 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcin-cb marcin-cb marcin-cb approved these changes

@deangalvin-cb deangalvin-cb Awaiting requested review from deangalvin-cb

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@drohit-cb @cb-heimdall @marcin-cb