chore: add networkId to WalletData

CHANGELOG.md

@@ -11,6 +11,8 @@
 - Add getters for `Validator` object to expose more data to users.
 - Add test file for `Validator` object.
 
+- Add `networkId` to `WalletData` so that it is saved with the seed data and surfaced via the export function
+
 ### [0.11.3] - 2024-12-10
 
 ### Added

src/coinbase/types.ts

@@ -818,6 +818,7 @@ export enum FundOperationStatus {
 export type WalletData = {
   walletId: string;
   seed: string;
+  networkId: string;
 };
 
 /**
@@ -828,6 +829,7 @@ export type SeedData = {
   encrypted: boolean;
   authTag: string;
   iv: string;
+  networkId: string;
 };
 
 /**

src/coinbase/wallet.ts

@@ -221,7 +221,7 @@ export class Wallet {
     if (!this.seed) {
       throw new Error("Cannot export Wallet without loaded seed");
     }
-    return { walletId: this.getId()!, seed: this.seed };
+    return { walletId: this.getId()!, seed: this.seed, networkId: this.getNetworkId() };
   }
 
   /**
@@ -631,6 +631,7 @@ export class Wallet {
       encrypted: encrypt,
       authTag: authTag,
       iv: iv,
+      networkId: data.networkId,
     };
 
     fs.writeFileSync(filePath, JSON.stringify(existingSeedsInStore, null, 2), "utf8");

src/tests/e2e.ts

@@ -54,7 +54,11 @@ describe("Coinbase SDK E2E Test", () => {
     const walletId = Object.keys(seedFile)[0];
     const seed = seedFile[walletId].seed;
 
-    const importedWallet = await Wallet.import({ seed, walletId });
+    const importedWallet = await Wallet.import({
+      seed,
+      walletId,
+      networkId: Coinbase.networks.BaseSepolia,
+    });
     expect(importedWallet).toBeDefined();
     expect(importedWallet.getId()).toBe(walletId);
     console.log(
@@ -138,6 +142,7 @@ describe("Coinbase SDK E2E Test", () => {
       encrypted: false,
       authTag: "",
       iv: "",
+      networkId: exportedWallet.networkId,
     });
   }, 60000);
 });

src/tests/wallet_test.ts

@@ -1197,6 +1197,7 @@ describe("Wallet Class", () => {
       expect(walletSeedData[walletId].iv).toBe("");
       expect(walletSeedData[walletId].authTag).toBe("");
       expect(walletSeedData[walletId].seed).toBe(seed);
+      expect(walletSeedData[walletId].networkId).toBe(seedWallet.getNetworkId());
     });
 
     it("should save the seed when encryption is true", async () => {