chore: add networkId to WalletData

coinbase · Dec 17, 2024 · 903b867 · 903b867
1 parent e9ccb2c
commit 903b867
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 2 deletions.
diff --git a/src/coinbase/types.ts b/src/coinbase/types.ts
@@ -816,6 +816,7 @@ export enum FundOperationStatus {
 export type WalletData = {
   walletId: string;
   seed: string;
+  networkId: string;
 };
 
 /**
@@ -826,6 +827,7 @@ export type SeedData = {
   encrypted: boolean;
   authTag: string;
   iv: string;
+  networkId: string;
 };
 
 /**

diff --git a/src/coinbase/wallet.ts b/src/coinbase/wallet.ts
@@ -221,7 +221,7 @@ export class Wallet {
     if (!this.seed) {
       throw new Error("Cannot export Wallet without loaded seed");
     }
-    return { walletId: this.getId()!, seed: this.seed };
+    return { walletId: this.getId()!, seed: this.seed, networkId: this.getNetworkId() };
   }
 
   /**
@@ -631,6 +631,7 @@ export class Wallet {
       encrypted: encrypt,
       authTag: authTag,
       iv: iv,
+      networkId: data.networkId,
     };
 
     fs.writeFileSync(filePath, JSON.stringify(existingSeedsInStore, null, 2), "utf8");

diff --git a/src/tests/e2e.ts b/src/tests/e2e.ts
@@ -54,7 +54,11 @@ describe("Coinbase SDK E2E Test", () => {
     const walletId = Object.keys(seedFile)[0];
     const seed = seedFile[walletId].seed;
 
-    const importedWallet = await Wallet.import({ seed, walletId });
+    const importedWallet = await Wallet.import({
+      seed,
+      walletId,
+      networkId: Coinbase.networks.EthereumMainnet,
+    });
     expect(importedWallet).toBeDefined();
     expect(importedWallet.getId()).toBe(walletId);
     console.log(
@@ -138,6 +142,7 @@ describe("Coinbase SDK E2E Test", () => {
       encrypted: false,
       authTag: "",
       iv: "",
+      networkId: exportedWallet.networkId,
     });
   }, 60000);
 });

diff --git a/src/tests/wallet_test.ts b/src/tests/wallet_test.ts
@@ -1197,6 +1197,7 @@ describe("Wallet Class", () => {
       expect(walletSeedData[walletId].iv).toBe("");
       expect(walletSeedData[walletId].authTag).toBe("");
       expect(walletSeedData[walletId].seed).toBe(seed);
+      expect(walletSeedData[walletId].networkId).toBe(seedWallet.getNetworkId());
     });
 
     it("should save the seed when encryption is true", async () => {