Merge pull request #337 from coinbase/christopher.gerber/feat/wallet-…

…address-invoke-contract-input-validation

feat: wallet address invoke contract input validation

CHANGELOG.md

@@ -2,6 +2,10 @@
 
 ## Unreleased
 
+### Added
+
+- Wallet address contract invocation input validation for payable contracts.
+
 ### [0.11.2] - 2024-12-04
 
 ### Added

src/coinbase/address/wallet_address.ts

@@ -325,6 +325,12 @@ export class WalletAddress extends Address {
       throw new Error("Cannot invoke contract from address without private key loaded");
     }
 
+    if (amount && !assetId) {
+      throw new ArgumentError(
+        "Asset ID is required for contract ivocation if an amount is provided",
+      );
+    }
+
     let atomicAmount: string | undefined;
 
     if (assetId && amount) {

src/tests/wallet_address_test.ts

@@ -1360,6 +1360,22 @@ describe("WalletAddress", () => {
         });
       });
 
+      describe("when it is fails to invoke a payable contract method", () => {
+        let amount = new Decimal("1000");
+
+        it("throws an error for invalid input", async () => {
+          await expect(
+            walletAddress.invokeContract({
+              abi: MINT_NFT_ABI,
+              args: MINT_NFT_ARGS,
+              method: VALID_CONTRACT_INVOCATION_MODEL.method,
+              contractAddress: VALID_CONTRACT_INVOCATION_MODEL.contract_address,
+              amount,
+            }),
+          ).rejects.toThrow(Error);
+        });
+      });
+
       describe("when no key is loaded", () => {
         beforeEach(() => {
           walletAddress = new WalletAddress(addressModel);