Implementing wallet.createWallet #16
Conversation
src/coinbase/tests/coinbase_test.ts
Outdated
| expect(user.toString()).toBe("User{ userId: 123 }"); | ||
| }); | ||
|
|
||
| it("should able to get faucet funds", async () => { |
There was a problem hiding this comment.
| it("should able to get faucet funds", async () => { | |
| it("should be able to get faucet funds", async () => { |
src/coinbase/types.ts
Outdated
| /** | ||
| * Returns the wallet model with the given ID. | ||
| * | ||
| * @param walletId - The ID of the wallet to fetch |
There was a problem hiding this comment.
| * @param walletId - The ID of the wallet to fetch | |
| * @param walletId - The ID of the wallet to fetch. |
src/coinbase/types.ts
Outdated
| * | ||
| * @param walletId - The ID of the wallet to fetch | ||
| * @param options - Override http request option. | ||
| * @throws {APIError} |
There was a problem hiding this comment.
| * @throws {APIError} | |
| * @throws {APIError} If the request fails. |
| * @throws {InternalError} - If address derivation or caching fails. | ||
| * @returns the new Wallet |
There was a problem hiding this comment.
Lets be consistent on if we add the - or not. Also for ending doc strings with period
There was a problem hiding this comment.
No need to use - for @throws or @return. However, it is necessary to use - for @params. I will investigate how we can extend this functionality.
There was a problem hiding this comment.
Tracking with PSDK-135
| private deriveKey(): ETHWallet { | ||
| private deriveKey(): HDKey { |
There was a problem hiding this comment.
Not blocking but it would be nice for us to continue using ethers.Wallet for the Key since that is what will be required to pass to the Address constructor. We can come up with a story for this in the Address.Transfer PR if you prefer not to block.
| */ | ||
| public getPublicKey(): string { |
There was a problem hiding this comment.
@yuga-cb's feedback
| * @throws {InternalError} - If address derivation or caching fails. | ||
| * @returns the new Wallet |
There was a problem hiding this comment.
No need to use - for @throws or @return. However, it is necessary to use - for @params. I will investigate how we can extend this functionality.
What changed? Why?
Implementing wallet.createWallet
Qualified Impact