Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

revert wallet level historical balance call #178

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

revert wallet level historical balance call #178

wants to merge 1 commit into from

Conversation

xinyu-li-cb
Copy link
Contributor

@xinyu-li-cb xinyu-li-cb commented Aug 22, 2024 •
edited
Loading

What changed? Why?

revert wallet level historical balance call to avoid confusion

Qualified Impact

@cb-heimdall
Copy link

cb-heimdall commented Aug 22, 2024 •
edited
Loading

🟡 Heimdall Review Status

Requirement Status More Info
Reviews 🟡 0/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 1
Sum 2

@xinyu-li-cb xinyu-li-cb marked this pull request as ready for review August 22, 2024 22:30
@cb-heimdall
Copy link

Review Error for melissamforbs @ 2024-09-10 12:01:45 UTC
User must have write permissions to review

@cb-heimdall
Copy link

Review Error for melissamforbs @ 2024-10-01 16:19:15 UTC
User must have write permissions to review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@melissamforbs melissamforbs melissamforbs approved these changes

@alex-stone alex-stone Awaiting requested review from alex-stone

@John-peterson-coinbase John-peterson-coinbase Awaiting requested review from John-peterson-coinbase

@jazz-cb jazz-cb Awaiting requested review from jazz-cb

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xinyu-li-cb @cb-heimdall @melissamforbs