Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Hotfix] Ensure all types are exported in index.ts #264

Merged
merged 4 commits into from
Sep 23, 2024
Merged

[Hotfix] Ensure all types are exported in index.ts #264

merged 4 commits into from
Sep 23, 2024

Conversation

rohan-agarwal-coinbase
Copy link
Contributor

What changed? Why?

  • Ensures all types are exported and adds a unit test to check for at least one property within each exported file

Testing

Unit test passes

@cb-heimdall
Copy link

cb-heimdall commented Sep 23, 2024 •
edited
Loading

✅ Heimdall Review Status

Requirement Status More Info
Reviews ✅ 1/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@rohan-agarwal-coinbase rohan-agarwal-coinbase changed the title Ensure all types are exported in index.ts [Hotfix] Ensure all types are exported in index.ts Sep 23, 2024
jazz-cb
jazz-cb previously approved these changes Sep 23, 2024
View reviewed changes
@jazz-cb jazz-cb self-requested a review September 23, 2024 22:00
@jazz-cb
Copy link
Contributor

jazz-cb commented Sep 23, 2024

@rohan-agarwal-coinbase let's alsp update package.json

@cb-heimdall cb-heimdall dismissed jazz-cb’s stale review September 23, 2024 22:23

Approved review 2323600982 from jazz-cb is now dismissed due to new commit. Re-request for approval.

@rohan-agarwal-coinbase rohan-agarwal-coinbase merged commit e74faca into master Sep 23, 2024
6 checks passed
@rohan-agarwal-coinbase rohan-agarwal-coinbase deleted the rohan/fix-types branch September 23, 2024 22:28
rohan-agarwal-coinbase added a commit that referenced this pull request Sep 23, 2024
@rohan-agarwal-coinbase
[Hotfix] Ensure all types are exported in index.ts (#264)
09462e5
rohan-agarwal-coinbase added a commit that referenced this pull request Sep 23, 2024
@rohan-agarwal-coinbase
[Hotfix] Ensure all types are exported in index.ts (#264)
967cb19 
(cherry picked from commit e74faca)
rohan-agarwal-coinbase added a commit that referenced this pull request Sep 23, 2024
@rohan-agarwal-coinbase
[Hotfix] Ensure all types are exported in index.ts (#264) (#266)
6747966 
(cherry picked from commit e74faca)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jazz-cb jazz-cb jazz-cb approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rohan-agarwal-coinbase @cb-heimdall @jazz-cb