Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(CDF-3933): Add Vercel support to discord bot implementation #308

Merged
merged 4 commits into from
Oct 31, 2024
Merged

feat(CDF-3933): Add Vercel support to discord bot implementation #308

merged 4 commits into from
Oct 31, 2024

Conversation

jair-rosa-cb
Copy link
Contributor

What changed? Why?

  • Adding a version of server that works on Vercel

Qualified Impact

@cb-heimdall
Copy link

cb-heimdall commented Oct 30, 2024 •
edited
Loading

✅ Heimdall Review Status

Requirement Status More Info
Reviews ✅ 1/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

cb-davidlai
cb-davidlai previously approved these changes Oct 30, 2024
View reviewed changes
@cb-heimdall cb-heimdall dismissed cb-davidlai’s stale review October 30, 2024 19:47

Approved review 2406093894 from cb-davidlai is now dismissed due to new commit. Re-request for approval.

@jair-rosa-cb jair-rosa-cb merged commit afd6b1b into master Oct 31, 2024
6 checks passed
@jair-rosa-cb jair-rosa-cb deleted the discord-bot-vercel branch October 31, 2024 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cb-davidlai cb-davidlai cb-davidlai approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jair-rosa-cb @cb-heimdall @cb-davidlai