Fix Asset fromModel bug to use passed in asset_id when initializing #317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🟡 Heimdall Review Status
|
rohan-agarwal-coinbase
force-pushed
the
rohan/fix-asset-from-model
branch
from
69b89fa to
a42eb0d
Compare
alex-stone
approved these changes
Nov 21, 2024
Merged
alex-stone
added a commit
that referenced
this pull request
Nov 27, 2024
* Update staking API client for updated openapi spec (#316) * Fix Asset fromModel bug to use passed in asset_id when initializing (#317) * feat: update client to include rlp_encoded_tx field within EthereumTransaction * add staking e2e tests * feat: Add source & source version attribution This adds the source & source version attribution handling. This makes it so that when configuring the SDK, the `source` and `sourceVersion` can be configured and passed through as correlation context for attribution on the backend. This will make it so we can easily attribute AgentKit requests to the specific version. * Support for fund and quote_fund for wallet funding (#322) * chore: Add source/source version to configure from JSON * chore: update stake build test to use mainnet to reduce falkiness observed on testnet * chore: Prep v0.11.0 release --------- Co-authored-by: rohan-agarwal-coinbase <[email protected]> Co-authored-by: Rohit Durvasula <[email protected]> Co-authored-by: Rohit Durvasula <[email protected]> Co-authored-by: Howard Xie <[email protected]> Co-authored-by: cb-howardatcb <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why?
See coinbase/cdp-sdk-python#46 for context. This is the fix for the Node SDK
Testing
Qualified Impact