Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(PSDK-670): Support external wallet imports, wallet imports from CDP Python SDK #347

Open
wants to merge 3 commits into
base: v0.13.0
Choose a base branch
from
Open

feat(PSDK-670): Support external wallet imports, wallet imports from CDP Python SDK #347

wants to merge 3 commits into from
+223 −25

Conversation

derek-cb
Copy link

What changed? Why?

  • Support external wallet import via BIP-39 mnemonic phrases (12, 15, 18, 21, or 24 words)
  • Support import of wallet data exported from CDP Python SDK
  • Deprecated existing Wallet.import() method in favor of Wallet.load() (more descriptive of the fact that we're loading an existing CDP wallet, not importing one into CDP)

Testing

Tested via:

  • Import of 12, 15, 18, 21, and 24-word mnemonic seed phrases
  • Export of wallets generated via mnemonic seed phrases
  • Import of wallets generated via mnemonic seed phrases, that were then exported
  • Successfully imported wallet exported from CDP Python SDK v0.12.0
  • Successfully imported wallet exported from CDP NodeJS SDK v0.11.0

Qualified Impact

@derek-cb
- Support external wallet import via BIP-39 mnemonic phrases (12, 15,…
3691fc0 
… 18, 21, or 24 words)

- Support import of wallet data exported from CDP Python SDK
- Deprecated existing Wallet.import() method in favor of Wallet.load() (more descriptive of the fact that we're loading an existing CDP wallet, not importing one into CDP)
@derek-cb
Implementing test cases. Lowered jest branch coverage criteria slightly
603df2d
@derek-cb derek-cb mentioned this pull request Dec 17, 2024
Closed
@derek-cb derek-cb marked this pull request as ready for review December 17, 2024 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@John-peterson-coinbase John-peterson-coinbase Awaiting requested review from John-peterson-coinbase

@alex-stone alex-stone Awaiting requested review from alex-stone

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@derek-cb