-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release V0.11.0 #219
Merged
Merged
Release V0.11.0 #219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### What changed? Why? This bumps the OpenAPI client version and fixes the client API names * `Wallet Stake` => `MPC Wallet Stake` * `Validators` -> `Stake` #### Qualified Impact <!-- Please evaluate what components could be affected and what the impact would be if there was an error. How would this error be resolved, e.g. rollback a deploy, push a new fix, disable a feature flag, etc... --> This should have no impact and should be a no-op
### What changed? Why? This fixes Smart Contract reads with no ABI specified. We support using ABIs from our deployed smart contracts and well known asset standards, namely ERC20, ERC721, and ERC1155 token contracts. ### How to test this Make a request to read a well known ERC20 asset without specifying an ABI: ``` asset = Coinbase::Asset.fetch('base-sepolia', 'usdc') Coinbase::SmartContract.read( network: Coinbase::Network::BASE_SEPOLIA, contract_address: asset.address_id, method: 'balanceOf', args: { account: "alexstone.base.eth"}, ) ``` #### Qualified Impact <!-- Please evaluate what components could be affected and what the impact would be if there was an error. How would this error be resolved, e.g. rollback a deploy, push a new fix, disable a feature flag, etc... -->
### What changed? Why? This adds support for funding wallets for a given Crypto Asset and amount, using your Coinbase accounts as the source of funds to buy the asset. Note:: This is an Alpha feature and you must reach out on the CDP SDK Discord to opt in. This enables quoting a fund operation #### Creating a fund quote and then executing it: ``` wallet = Coinbase::Wallet.create(network: Coinbase::Network::BASE_MAINNET) # Generate a quote quote = wallet.quote_fund(12, :usdc) # Inspect quote.buy_fee (fiat) and quote.transfer_fee (crypto) puts quote # Execute the fund operation op = quote.execute! # Wait for the fund operation to complete. This could take a while since this involves off-chain + on-chain interactions. op.wait! ``` #### Fund a wallet ``` wallet = Coinbase::Wallet.create(network: Coinbase::Network::BASE_MAINNET) # Generate a fund operation op = wallet.fund(12, :usdc) # Wait for the fund operation to complete. This could take a while since this involves off-chain + on-chain interactions. op.wait! ``` #### Qualified Impact <!-- Please evaluate what components could be affected and what the impact would be if there was an error. How would this error be resolved, e.g. rollback a deploy, push a new fix, disable a feature flag, etc... -->
### What changed? Why? This bumps the version and updates the Changelog #### Qualified Impact <!-- Please evaluate what components could be affected and what the impact would be if there was an error. How would this error be resolved, e.g. rollback a deploy, push a new fix, disable a feature flag, etc... -->
✅ Heimdall Review Status
|
alex-stone
requested review from
rohan-agarwal-coinbase and
John-peterson-coinbase
November 27, 2024 20:50
John-peterson-coinbase
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why?
Added
Fixed
Changes
#216
#217
#215
#218
Qualified Impact