-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add address reputation #221
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Heimdall Review Status
|
alex-stone
force-pushed
the
stone/address-reputation
branch
2 times, most recently
from
December 11, 2024 17:58
39ca4a4
to
43f0081
Compare
alex-stone
commented
Dec 12, 2024
alex-stone
commented
Dec 12, 2024
alex-stone
commented
Dec 12, 2024
alex-stone
commented
Dec 12, 2024
alex-stone
commented
Dec 12, 2024
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This adds support for fetching an address' reputation lazily. Example: ``` risky_address = Coinbase::Address.new(:ethereum_mainnet, '0x12846c6Fd6baBFE4bC6F761eB871eFfFDEb26913') // Returns the reputation of the address risky_address.reputation // Returns whether the address itself is deemed "risky" risky_address.risky? => true ```
This adds tests for the address reputation object as well as for the usage of it within all of the address constructs.
alex-stone
force-pushed
the
stone/address-reputation
branch
from
December 13, 2024 17:55
edd83e0
to
0acc672
Compare
alex-stone
requested review from
John-peterson-coinbase,
jazz-cb,
rohan-agarwal-coinbase and
derek-cb
December 13, 2024 17:56
alex-stone
force-pushed
the
stone/address-reputation
branch
from
December 13, 2024 21:20
d169d91
to
995413d
Compare
jazz-cb
previously approved these changes
Dec 17, 2024
jazz-cb
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why?
This adds support for fetching an address' reputation lazily.
Example:
Qualified Impact