Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix export to account for basePath #1461

Merged
merged 3 commits into from
Dec 10, 2024
Merged

Fix export to account for basePath #1461

merged 3 commits into from
Dec 10, 2024

Conversation

cb-jake
Copy link
Contributor

@cb-jake cb-jake commented Dec 10, 2024 •
edited
Loading

Summary

Fix export to account for basePath

How did you test your changes?

From the root run yarn deploy

Validate there is an out directory inside the sdk playground directory. Make sure it has a .nojekyll file inside the out dir

@cb-heimdall
Copy link
Collaborator

cb-heimdall commented Dec 10, 2024 •
edited
Loading

✅ Heimdall Review Status

Requirement Status More Info
Reviews ✅ 1/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@cb-jake cb-jake merged commit eda84de into master Dec 10, 2024
7 checks passed
@cb-jake cb-jake deleted the fix-builds branch December 10, 2024 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spencerstock spencerstock spencerstock approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cb-jake @cb-heimdall @spencerstock