Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update go-ethereum's version to v1.13.14 #118

Merged

Conversation

songge-cb
Copy link
Contributor

Motivation

An issue was found on the calculated hash from header code. The hash value does not match the value on the network explorer. The root cause is the struct Header is defined in the dependency package go-ethereum and had new fields added. So we need to update the dependency.

Solution

  • Updated the version of go-ethereum to the latest, ie v1.13.14.
  • Updated the data types in some functions and some deprecated function calls due to the data type change in go-ethereum
  • Removed Ropsten and Rinkeby networks because they are deprecated.
  • Added Sepolia network

Open questions

@songge-cb songge-cb force-pushed the songge/updateGoEthereumVersion branch from d698f8b to dbfb279 Compare March 8, 2024 00:47
@GeekArthur GeekArthur merged commit 0949ece into coinbase:master Mar 8, 2024
8 checks passed
@songge-cb songge-cb deleted the songge/updateGoEthereumVersion branch March 11, 2024 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants