-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rebase weiwang pr #490
Open
jingweicb
wants to merge
6
commits into
master
Choose a base branch
from
rebase-weiwang-pr
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Rebase weiwang pr #490
Commits on Jul 22, 2023
-
feat: Guarantee the order of transactions in the block endpoint
This commit guarantees the order of transactions in the block endpoint. It does so by creating a map of fetched transactions and using that map to return the transactions in the original order they had in the block. - Added a new struct `FetchedTransaction` to represent fetched transactions - Updated `fetchChannelTransactions` to use the new `FetchedTransaction` struct - Updated `UnsafeTransactions` to use the new `FetchedTransaction` struct and create a map of fetched transactions - Modified the return statement in `UnsafeTransactions` to use the fetched transactions from the map
Configuration menu - View commit details
-
Copy full SHA for f4830e1 - Browse repository at this point
Copy the full SHA f4830e1View commit details -
chore: add timeout to mock server
This commit adds a timeout to the mock server to prevent it from hanging indefinitely. This is mainly to make salus security scans happy.
Configuration menu - View commit details
-
Copy full SHA for 462412e - Browse repository at this point
Copy the full SHA 462412eView commit details -
chore: avoid memory leak in client
This commit fixes a memory leak in the client. The client was not reading the response body of the http request when closing the body, which could lead to a memory leak. This commit fixes this by reading the response body and discarding it. This commit makes salus check pass.
Configuration menu - View commit details
-
Copy full SHA for 7cf1d78 - Browse repository at this point
Copy the full SHA 7cf1d78View commit details
Commits on Jul 23, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 73a13a8 - Browse repository at this point
Copy the full SHA 73a13a8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 17e0538 - Browse repository at this point
Copy the full SHA 17e0538View commit details
Commits on Jul 24, 2023
-
Configuration menu - View commit details
-
Copy full SHA for c18a595 - Browse repository at this point
Copy the full SHA c18a595View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.