chore: Update zora contract #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
abcrane123
commented
Aug 8, 2024
| console.error('Transaction error:', err); | ||
| }; | ||
|
|
||
| const handleSuccess = (response: any) => { |
There was a problem hiding this comment.
we need to export TransactionResponse from onchainkit
There was a problem hiding this comment.
Zizzamia
reviewed
Aug 8, 2024
| import type { Address, ContractFunctionParameters } from 'viem'; | ||
| import { parseEther } from 'viem'; | ||
|
|
||
| const BASE_SEPOLIA_CHAIN_ID = 84532; |
There was a problem hiding this comment.
let's move this to constant file
Zizzamia
reviewed
Aug 8, 2024
| const tokenId = '1'; | ||
| const quantity = '1'; | ||
| const mintReferral = '0x0000000000000000000000000000000000000000'; | ||
| const comment = 'testing'; |
There was a problem hiding this comment.
Same here, let's use more polish constant.
Zizzamia
approved these changes
Aug 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why?
Notes to reviewers
How has it been tested?