fix optional params - revisit

coinbase · Dec 16, 2024 · 036a58a · 036a58a
1 parent 947b6b8
commit 036a58a
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 7 deletions.
diff --git a/src/core/api/getSwapLiteQuote.ts b/src/core/api/getSwapLiteQuote.ts
@@ -16,7 +16,7 @@ type GetSwapLiteQuoteResponse = {
 };
 
 type GetSwapLiteQuoteParams = Omit<GetSwapQuoteParams, 'from'> & {
-  fromSwapUnit: SwapUnit;
+  fromSwapUnit?: SwapUnit;
   from?: Token;
 };
 
@@ -48,7 +48,7 @@ export async function getSwapLiteQuote({
   }
 
   let formattedFromAmount = '';
-  if (response && !isSwapError(response)) {
+  if (response && !isSwapError(response) && fromSwapUnit) {
     formattedFromAmount = formatTokenAmount(
       response.fromAmount,
       response.from.decimals,

diff --git a/src/swap/components/SwapLiteProvider.tsx b/src/swap/components/SwapLiteProvider.tsx
@@ -257,13 +257,13 @@ export function SwapLiteProvider({
         to.setAmountUSD('');
         fromETH.setAmountUSD('');
         fromUSDC.setAmountUSD('');
-        from.setAmountUSD('');
+        from?.setAmountUSD('');
         return;
       }
 
       fromETH.setLoading(true);
       fromUSDC.setLoading(true);
-      from.setLoading(true);
+      from?.setLoading(true);
 
       updateLifecycleStatus({
         statusName: 'amountChange',
@@ -276,7 +276,7 @@ export function SwapLiteProvider({
           amountFrom: '',
           tokenFromETH: fromETH.token,
           tokenFromUSDC: fromUSDC.token,
-          tokenFrom: from.token,
+          tokenFrom: from?.token,
           tokenTo: to.token,
           // when fetching quote, the destination
           // amount is missing
@@ -353,7 +353,7 @@ export function SwapLiteProvider({
             amountTo: amount,
             tokenFromETH: fromETH.token,
             tokenFromUSDC: fromUSDC.token,
-            tokenFrom: from.token,
+            tokenFrom: from?.token,
             tokenTo: to.token,
             // if quote was fetched successfully, we
             // have all required fields
@@ -373,7 +373,7 @@ export function SwapLiteProvider({
         // reset loading state when quote request resolves
         fromETH.setLoading(false);
         fromUSDC.setLoading(false);
-        from.setLoading(false);
+        from?.setLoading(false);
       }
     },
     [