Add getMaxSlippage

coinbase · Sep 10, 2024 · 431fb76 · 431fb76
1 parent 428ecd3
commit 431fb76
Showing 1 changed file with 11 additions and 8 deletions.
diff --git a/src/swap/components/SwapProvider.tsx b/src/swap/components/SwapProvider.tsx
@@ -69,6 +69,12 @@ export function SwapProvider({
   // Refreshes balances and inputs post-swap
   const resetInputs = useResetInputs({ from, to });
 
+  const getMaxSlippage = useCallback(() => {
+    return lifeCycleStatus.statusName !== 'error'
+      ? lifeCycleStatus.statusData.maxSlippage
+      : experimental.maxSlippage || DEFAULT_MAX_SLIPPAGE;
+  }, [lifeCycleStatus, experimental.maxSlippage]);
+
   // Component lifecycle emitters
   useEffect(() => {
     // Error
@@ -118,17 +124,18 @@ export function SwapProvider({
   }, [hasHandledSuccess, lifeCycleStatus.statusName, resetInputs]);
 
   useEffect(() => {
+    const maxSlippage = getMaxSlippage();
     // Reset status to init after success has been handled
     if (lifeCycleStatus.statusName === 'success' && hasHandledSuccess) {
       setLifeCycleStatus({
         statusName: 'init',
         statusData: {
           isMissingRequiredField: false,
-          maxSlippage: initialMaxSlippage,
+          maxSlippage,
         },
       });
     }
-  }, [hasHandledSuccess, lifeCycleStatus.statusName, initialMaxSlippage]);
+  }, [hasHandledSuccess, lifeCycleStatus.statusName]);
 
   const handleToggle = useCallback(() => {
     from.setAmount(to.amount);
@@ -248,17 +255,14 @@ export function SwapProvider({
         destination.setLoading(false);
       }
     },
-    [from, initialMaxSlippage, to, useAggregator],
+    [from, to, useAggregator],
   );
 
   const handleSubmit = useCallback(async () => {
     if (!address || !from.token || !to.token || !from.amount) {
       return;
     }
-    const maxSlippage =
-      lifeCycleStatus.statusName !== 'error'
-        ? lifeCycleStatus.statusData.maxSlippage
-        : DEFAULT_MAX_SLIPPAGE;
+    const maxSlippage = getMaxSlippage();
     setLifeCycleStatus({
       statusName: 'init',
       statusData: {
@@ -316,7 +320,6 @@ export function SwapProvider({
     from.amount,
     from.token,
     lifeCycleStatus,
-    initialMaxSlippage,
     sendTransactionAsync,
     to.token,
     useAggregator,